Log feature: OsRng improvements #250
Conversation
|
Looks good to me! |
src/os.rs
Outdated
| if err_count >= log_err { | ||
| log_err += TRANSIENT_STEP; | ||
| warn!("OsRng: retrying ..."); | ||
| err_count += RETRY_LIMIT / TRANSIENT_RETRIES; |
There was a problem hiding this comment.
Because this is not a perfect division, it will retry 9 times instead of 8. Do we care about that? To round correctly it would have to be err_count += (RETRY_LIMIT + TRANSIENT_RETRIES - 1) / TRANSIENT_RETRIES;
There was a problem hiding this comment.
Good point. It doesn't matter a lot, but maybe we should tweak the constants so that RETRY_LIMIT is a multiple of TRANSIENT_RETRIES.
There was a problem hiding this comment.
I like division with rounding up (which my line in the comment above does) a little more than being careful with the constant to pick. But as we picked it basically arbitrary, the only somewhat important thing is that it runs the same number of times as we claim in the constant and logging.
Log feature: OsRng improvements
Mostly @pitdicker's code with a few tweaks by myself
I didn't realize using
strerrorwas valid with CloudABI but apparently it is.